Restructuring psibase macros #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
e5f4f90
to
260bf16
Compare
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
f60e1b9
to
3c50f06
Compare
…e; repo is building
…f attrs and mod working; code compiles
…yet split into modules
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
ce554f8
to
1629e23
Compare
James-Mart
reviewed
Oct 28, 2024
| } | ||
| }; | ||
|
|
||
| service_macro_impl(attr, before); |
There was a problem hiding this comment.
servicemacro should expand without requiring auseto provide its deps
Does this actually check that the generated TokenStream compiles though?
There was a problem hiding this comment.
No, it only tests that the macro doesn't find syntax it doesn't recognize.
cool-ant
force-pushed
the
mm/restructing-psibase-macros
branch
from
56a35bb
to
4291bab
Compare
swatanabe
reviewed
Nov 12, 2024
James-Mart
approved these changes
Nov 12, 2024
Was this addressed? |
It is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the psibase_macros into a 3-project workspace for easier dev/testing.
In addition to the 3-project structure, it also splits service_macro.rs into separate files for better readability/maintainability.
There are a couple of TODOs but only in the test files and are notes for tests I can add; nothing functionally missing from this PR.
All files in the
rust/psibase_macros/psibase-macros-lib/src/service_macro/dir is unmodified code simply spilt out from the single formerlyrust/psibase_macros/psibase-macros-lib/src/service_macro.rsinto more bite-sized chunks.