-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support invite accept reject #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the domain of the active (top-level) application
James-Mart
added
the
System app
Related to system services and their apps/plugins
label
Oct 21, 2024
…y auth-notifier. Unlike the auth service pluign, auth-notifiers should not be privy to the entire transaction data.
James-Mart
commented
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was tempted to just put this in transact/plugin/deps/
. I figured leaving it next to export.wit
will help ensure that these stay in sync
swatanabe
reviewed
Oct 25, 2024
swatanabe
approved these changes
Oct 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two important improvements for user management:
invite
plugin can now be accepted/rejected. If accepted, a new account is created.Changes overview
invite
pluginauthsig
,authany
,authinvite
,authdelegate
authdelegate
is still just a skeleton. Accounts usingauthdelegate
will fail to send transactions.transact
plugin: attach correct claims/proofs to each transactionaccounts
plugin