Fixing anyhow references in service macro #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-ant
force-pushed
the
mm/anyhow-fix
branch
from
b5f507e
to
7382a69
Compare
swatanabe
reviewed
Nov 13, 2024
| @@ -48,4 +48,25 @@ mod tests { | |||
|
|
|||
| let _after = service_macro_impl(attr, before); | |||
| } | |||
|
|
|||
| #[test] | |||
| // `service` macro should expand without requiring a `use` to provide its deps | |||
There was a problem hiding this comment.
It always expanded successfully. The generated code just didn't compile.
There was a problem hiding this comment.
ok, comment updated for accuracy.
And test_psibase_macros actually exercises this code, ensuring that the expanded code compiles.
There was a problem hiding this comment.
The original comment accurately described the test. It's just not a very useful test.
swatanabe
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.