Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net/gipv4): add enhanced the conversion between uint32 and string #3988

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

oldme-git
Copy link
Member

Dear Review:
增强 ipv4 地址的转换,包含大小端序

Closed: #3984

@gqcn
Copy link
Member

gqcn commented Nov 29, 2024

@oldme-git 对应的issue我回复了,似乎针对IP转LongInt没有必要提供小端序转换?

@gqcn gqcn added the discuss We need discuss to make decision. label Nov 29, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@oldme-git I replied to the corresponding issue. It seems that there is no need to provide little endian conversion for converting IP to LongInt?

@oldme-git
Copy link
Member Author

@gqcn 框架提供工具被,单设增设小端,之前的大端不动,你看行不行

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn The framework provides tools to add little endian. The previous big endian will remain unchanged. Can you see if it works?

@gqcn gqcn merged commit 9923975 into master Dec 1, 2024
40 checks passed
@gqcn gqcn deleted the enhance/gipv4_convert branch December 1, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss We need discuss to make decision.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net/gipv4: Ip2long is inconsistent with inet_addr in cpp
3 participants