Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Remove args of Provision method #67

Merged
merged 2 commits into from
May 22, 2020

Conversation

wangcanfengxs
Copy link
Contributor

Signed-off-by: wangcanfeng [email protected]

@wangcanfengxs wangcanfengxs self-assigned this May 18, 2020
@wangcanfengxs wangcanfengxs added the enhancement New feature or request label May 18, 2020
@wangcanfengxs wangcanfengxs modified the milestones: Sprint2, Sprint3 May 18, 2020
@wangcanfengxs wangcanfengxs linked an issue May 18, 2020 that may be closed by this pull request
Ghostbaby
Ghostbaby previously approved these changes May 18, 2020
…perator into feature/fix-provision

� Conflicts:
�	controllers/cache/redis.go
Copy link
Contributor

@Ghostbaby Ghostbaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Ghostbaby Ghostbaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@soulseen soulseen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soulseen soulseen merged commit a7e9e16 into goharbor:master May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REMOVE args of Provision method in Reconciler interface.
3 participants