Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Page.Markup #2669

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmooring
Copy link
Member

@jmooring jmooring commented Aug 13, 2024

@jmooring jmooring force-pushed the document-page-dot-contents branch from 9e1726b to c8f29f1 Compare August 14, 2024 14:13
@jmooring jmooring changed the title Document Page.Contents Document Page.Markup Aug 14, 2024
@jmooring jmooring force-pushed the document-page-dot-contents branch 2 times, most recently from a785a2d to af92049 Compare August 14, 2024 14:16
@jmooring jmooring force-pushed the document-page-dot-contents branch from af92049 to a267a50 Compare August 15, 2024 13:08

<!-- TODO -->

<!-- JMM It is unclear to me if things like .Page.WordCount will be deprecated in favor of .Page.Markup.CountWords. Three levels (Page, Markup, Countwords) is a bit of a pain to document with the current docs theme. Several of the Markup methods required their own page.
Copy link
Member

@bep bep Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to have the method live in both places forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants