forked from gocraft/work
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose web ui router for external server, and switch to *http.ServeMux from gocraft/web #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Action items from discussion with @chopraanmol1 via DM:
Proposed structure: func NewServer(namespace string, pool *redis.Pool, hostPort string) *Server {
...
client = work.NewClient(namespace, pool)
router = buildRouter(client)
...
}
func NewRouter(namespace string, pool *redis.Pool) *web.Router {
...
client = work.NewClient(namespace, pool)
return buildRouter(client)
}
func buildRouter(*work.Client) *web.Router {
....
} EDIT 2024/09/30: relative path is doable |
4556ce3
to
876d588
Compare
876d588
to
2774347
Compare
More action items with @chopraanmol1
|
- Update minimum supported golang version to 1.22 - Use explicit relative path on webui - Cleanup & refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #43