Improved code

Use MediaQuery.sizeOf(context) instead of MediaQuery.of(context).size to avoid unwanted rebuilding
gokadzev · Sep 4, 2024 · a902844 · a902844
1 parent e40469d
commit a902844
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/lib/screens/home_page.dart b/lib/screens/home_page.dart
@@ -144,7 +144,7 @@ class _HomePageState extends State<HomePage> {
   }
 
   Widget _buildPlaylistSection(BuildContext context, List<dynamic> playlists) {
-    final playlistHeight = MediaQuery.of(context).size.height * 0.25 / 1.1;
+    final playlistHeight = MediaQuery.sizeOf(context).height * 0.25 / 1.1;
 
     return Column(
       children: [
@@ -240,7 +240,7 @@ class _HomePageState extends State<HomePage> {
     required List<dynamic> data,
     bool showArtists = true,
   }) {
-    final contentHeight = MediaQuery.of(context).size.height * 0.25;
+    final contentHeight = MediaQuery.sizeOf(context).height * 0.25;
 
     return Column(
       children: [
@@ -313,7 +313,7 @@ class _HomePageState extends State<HomePage> {
         mainAxisAlignment: MainAxisAlignment.spaceBetween,
         children: [
           SizedBox(
-            width: MediaQuery.of(context).size.width * 0.7,
+            width: MediaQuery.sizeOf(context).width * 0.7,
             child: MarqueeWidget(
               child: Text(
                 title,

diff --git a/lib/screens/now_playing_page.dart b/lib/screens/now_playing_page.dart
@@ -45,7 +45,7 @@ class NowPlayingPage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final size = MediaQuery.of(context).size;
+    final size = MediaQuery.sizeOf(context);
 
     return Scaffold(
       appBar: AppBar(backgroundColor: Colors.transparent),

diff --git a/lib/screens/playlist_page.dart b/lib/screens/playlist_page.dart
@@ -163,7 +163,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
               ],
             )
           : SizedBox(
-              height: MediaQuery.of(context).size.height - 100,
+              height: MediaQuery.sizeOf(context).height - 100,
               child: const Spinner(),
             ),
     );
@@ -172,7 +172,7 @@ class _PlaylistPageState extends State<PlaylistPage> {
   Widget _buildPlaylistImage() {
     return PlaylistCube(
       _playlist,
-      size: MediaQuery.of(context).size.width / 2.5,
+      size: MediaQuery.sizeOf(context).width / 2.5,
       onClickOpen: false,
       cubeIcon: widget.cubeIcon,
       showFavoriteButton: false,

diff --git a/lib/screens/user_songs_page.dart b/lib/screens/user_songs_page.dart
@@ -143,7 +143,7 @@ class _UserSongsPageState extends State<UserSongsPage> {
       {'title': title},
       onClickOpen: false,
       showFavoriteButton: false,
-      size: MediaQuery.of(context).size.width / 2.5,
+      size: MediaQuery.sizeOf(context).width / 2.5,
       cubeIcon: icon,
     );
   }

diff --git a/lib/services/update_manager.dart b/lib/services/update_manager.dart
@@ -97,7 +97,7 @@ Future<void> checkAppUpdates() async {
               const SizedBox(height: 10),
               ConstrainedBox(
                 constraints: BoxConstraints(
-                  maxHeight: MediaQuery.of(context).size.height / 2.14,
+                  maxHeight: MediaQuery.sizeOf(context).height / 2.14,
                 ),
                 child: SingleChildScrollView(
                   child: AutoFormatText(text: releasesResponse['body']),

diff --git a/lib/utilities/flutter_bottom_sheet.dart b/lib/utilities/flutter_bottom_sheet.dart
@@ -23,7 +23,7 @@ import 'package:fluentui_system_icons/fluentui_system_icons.dart';
 import 'package:flutter/material.dart';
 
 void showCustomBottomSheet(BuildContext context, Widget content) {
-  final size = MediaQuery.of(context).size;
+  final size = MediaQuery.sizeOf(context);
   showBottomSheet(
     enableDrag: true,
     context: context,

diff --git a/lib/widgets/playlist_header.dart b/lib/widgets/playlist_header.dart
@@ -43,7 +43,7 @@ class PlaylistHeader extends StatelessWidget {
         image,
         const SizedBox(width: 10),
         SizedBox(
-          width: MediaQuery.of(context).size.width / 2.3,
+          width: MediaQuery.sizeOf(context).width / 2.3,
           child: Column(
             children: [
               Text(

diff --git a/lib/widgets/song_bar.dart b/lib/widgets/song_bar.dart
@@ -245,7 +245,7 @@ void showAddToPlaylistDialog(BuildContext context, dynamic song) {
         content: Container(
           width: double.maxFinite,
           constraints: BoxConstraints(
-            maxHeight: MediaQuery.of(context).size.height * 0.6,
+            maxHeight: MediaQuery.sizeOf(context).height * 0.6,
           ),
           child: userCustomPlaylists.isNotEmpty
               ? ListView.builder(