Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigQuery database driver #881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbobrovskyi
Copy link

@mbobrovskyi mbobrovskyi commented Feb 12, 2023

Add support for BigQuery database driver.

@mbobrovskyi mbobrovskyi changed the title Added BigQuery database driver WIP: Added BigQuery database driver Feb 12, 2023
@StevenACoffman
Copy link

Hey, I was comparing against #830 and I was just curious if you were going to pick this back up.

@mbobrovskyi
Copy link
Author

Hey, I was comparing against #830 and I was just curious if you were going to pick this back up.

Hi. I haven't found a stable emulator for the bigquery. That's why there are a lot of mistakes in testing.

BTW, it is working with real data.

@mbobrovskyi mbobrovskyi reopened this May 29, 2023
@StevenACoffman
Copy link

StevenACoffman commented May 29, 2023

Oh, have you tried https://github.com/goccy/bigquery-emulator ? I used it for a handful of tests and it worked reasonably well there. The DDL support is mostly CREATE TABLE | VIEW | FUNCTION, and corresponding DROP TABLE | VIEW | FUNCTION https://github.com/goccy/go-zetasqlite#status so it doesn't have all the ALTER support that one might want.

@mbobrovskyi
Copy link
Author

Oh, have you tried https://github.com/goccy/bigquery-emulator ? I used it for a handful of tests and it worked reasonably well there. The DDL support is mostly CREATE TABLE | VIEW | FUNCTION, and corresponding DROP TABLE | VIEW | FUNCTION https://github.com/goccy/go-zetasqlite#status so it doesn't have all the ALTER support that one might want.

Unfortunately bigquery-emulator didn't allow to use system variables. We are using it to set automaticaly '@@dataset_id' in migrations scripts. I have create issue for this case (goccy/bigquery-emulator#147).

And alse the problem is that dktest does not allow to open a custom port. I created a pull request (dhui/dktest#21) in order to allow opening the port manually, but so far no one has approved it.

@mbobrovskyi mbobrovskyi changed the title WIP: Added BigQuery database driver WIP: Support BigQuery database driver Sep 16, 2024
@mbobrovskyi mbobrovskyi marked this pull request as draft September 16, 2024 04:25
@mbobrovskyi mbobrovskyi changed the title WIP: Support BigQuery database driver Support BigQuery database driver Sep 16, 2024
@mbobrovskyi mbobrovskyi marked this pull request as ready for review September 22, 2024 11:20
@mbobrovskyi mbobrovskyi force-pushed the master branch 3 times, most recently from 5d4473d to a0b7408 Compare September 22, 2024 12:59
@mbobrovskyi
Copy link
Author

/cc @dhui

@mbobrovskyi
Copy link
Author

mbobrovskyi commented Sep 22, 2024

I'm not sure what's happening with the tests. It seems to be an issue with sqlserver. However, these changes are unrelated to that. I also tried to run it on master and I have the same issue.

@mbobrovskyi
Copy link
Author

Created an issue #1174.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants