Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/acme: Add support for custom validity certs #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crypto/acme: Add support for custom validity certs #242

wants to merge 1 commit into from
+15 −1

Conversation

daknob
Copy link

@daknob daknob commented Nov 29, 2022 •
edited
Loading

This commit allows autocert to request certificates with a specific notAfter value from the ACME CA. The CA may choose to honor this request or not. The acme package already supports this functionality, this CL brings this support to autocert as well.

@daknob
Add support for custom validity certs
4330f4e 
This commit allows autocert to request certificates with a specific notAfter
value from the ACME CA. The CA may choose to honor this request or not. The
acme package already supports this functionality.
@gopherbot
Copy link
Contributor

This PR (HEAD: 4330f4e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/454175 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Antonios Chariton:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/454175.
After addressing review feedback, remember to publish your drafts!

@daknob daknob changed the title Add support for custom validity certs crypto/acme: Add support for custom validity certs Nov 30, 2022
@gopherbot
Copy link
Contributor

Message from Antonios Chariton:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/454175.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Maxime Tremblay:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/454175.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daknob @gopherbot