-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if the only stream in a connection times out, prevent re-use #169
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: db3e8a7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/485715 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
This commit mitigates some raciness which can occur when an established connection fails. Without it, the connection can continue to be drawn from the connection pool, leading to subsequent requests failing. Fixes golang/go#59690
db3e8a7
to
613c39d
Compare
Commit message updated as noted in Gerrit |
This PR (HEAD: 613c39d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/485715 to see it. Tip: You can toggle comments from me using the |
Message from Damien Neil: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
This PR (HEAD: ab7b5a3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/485715 to see it. Tip: You can toggle comments from me using the |
Message from Ben Tasker: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
Message from Ben Tasker: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
Message from Ben Tasker: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. |
This commit mitigates some raciness which can occur when an established connection fails. Without it, the connection can continue to be drawn from the connection pool, leading to subsequent requests failing.
There may very well be a better way.
Details in golang/go#59690