-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/websocket: Add the Conn.FrameDataLength and NewClient2 #191
base: master
Are you sure you want to change the base?
Conversation
hybiClientHandshake: add return http.Response for NewClient
add NewClient2
add FrameDataLength
add FrameDataLength
add TestNewClient2
fixed test
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 50bf7ed) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/523615. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/523615. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/523615. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/523615. |
Add websocket.NewClient2 to get the http.Response returned by the server, so as to have better countermeasures when there is a handshake error.
Add the websocket.Conn.FrameDataLength method to return the data size of the frame to deal with the read and write logic of the frame.
Added TestNewClient2 test case and usage of FrameDataLength.