-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2/h2c: make the h2c connection docs available in godoc #218
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: d3d2e98) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/602715. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/602715. |
Message from Xie Yuchen: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/602715. |
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/602715. |
Change-Id: I37154fb64fa94ae57bd55463c78ea9c943ed2213 GitHub-Last-Rev: d3d2e98 GitHub-Pull-Request: golang#218
This PR (HEAD: 175c55f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/602715. Important tips:
|
Message from Xie Yuchen: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/602715. |
In the current godoc, we cannot see the description about how "h2c connection" is detected by h2c package so I need to read the code to see. Actually this part has been mentioned already but under an un-exported structure.
This PR tries to move it to the package level comments, so we could view it via the go doc.