Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: Specify Version 1.18 in go.mod #1403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jblz
Copy link

@jblz jblz commented Oct 3, 2022

When running the tour locally with default settings, the "Type parameters" example at http://127.0.0.1:3999/tour/generics/1 fails with the following error:
type parameter requires go1.18 or later (-lang was set to go1.16; check go.mod)

...even when running on 1.18+

I think updating the runtime version declaration here should fix that.

I'm not sure if this should be bumped to 1.19 or not, but feel free to set it such if desired.

@gopherbot
Copy link

This PR (HEAD: c37cabf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tour/+/438124 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/438124.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants