Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_content/tour/static/css/app.css: fix hidden horizontal scrollbar for long outputs #283

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Sanian-Creations
Copy link

@Sanian-Creations Sanian-Creations commented May 10, 2024

This fixes a problem where long outputs go off the screen and the
horizontal scrollbar is not visible (shift-scrolling is currently
possible but this isn't communicated to users), an example is the long
error message when running https://go.dev/tour/methods/9

calc(100% - 32px) fixes that this element stuck out 32px below the
bottom of the page (which hid the scrollbar that was there).
min-width: min-content fixes that this element would have its text
overflow off to the right.

This is a cosmetic fix, there is no bug report.

The calc(100% - 52px) corrects for the 32px that the .output element sticks out below the bottom of the page, and 20px for for the 10px padding that all pre tags have on the top and bottom. If this isn't corrected for then the vertical scrollbar is rendered below the bottom of the page.
Copy link

google-cla bot commented May 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: a6844bb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/584855.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/584855.
After addressing review feedback, remember to publish your drafts!

Fixed root cause of issue: the `#explorer + div` element was sticking out 32px below the page, not anymore.
`.output > pre` now uses box-sizing so that max-height 100% will always work regardless of any specific padding.
@gopherbot
Copy link
Contributor

This PR (HEAD: 8a9aabc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

change is now minimal
@Sanian-Creations Sanian-Creations changed the title Large outputs now show vertical scrollbar _content/tour/static/css/app.css: Large outputs now show horizontal scrollbar May 11, 2024
@gopherbot
Copy link
Contributor

This PR (HEAD: 6f7ecd3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/584855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@Sanian-Creations Sanian-Creations changed the title _content/tour/static/css/app.css: Large outputs now show horizontal scrollbar _content/tour/static/css/app.css: fix hidden horizontal scrollbar for long outputs May 11, 2024
@gopherbot
Copy link
Contributor

Message from Sanian Creations:

Patch Set 6: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/584855.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Sanian Creations:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/584855.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Sanian Creations:

Patch Set 6: -Code-Review


Please don’t reply on this GitHub thread. Visit golang.org/cl/584855.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants