-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_content/doc/tutorial: apply the "keep going" principle to "add a test" examples #297
base: master
Are you sure you want to change the base?
_content/doc/tutorial: apply the "keep going" principle to "add a test" examples #297
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Just redid the CLA. It was bugging out the first time, but it should be good now |
ee8db1c
to
ec26e44
Compare
This PR (HEAD: ec26e44) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/603335. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Hyang-Ah Hana Kim: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Hyang-Ah Hana Kim: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Robert Findley: Patch Set 2: Auto-Submit+1 Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-12T14:32:32Z","revision":"b3647d5a9c4e3eaf008eb0c2c3a8f4364b461fdf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Robert Findley: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/603335. |
Fixes golang/go#68741