Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇯🇵 Japanese Translation (Section1, 5) #242

Closed
wants to merge 26 commits into from

Conversation

yuichkun
Copy link

@yuichkun yuichkun commented Jan 17, 2023

Progress Tracking here: #183

Hi @goldbergyoni, sorry for not making this pull request earlier.

It was a while ago when @kawamataryo and I declared that we'd do the translation but then stopped because we were caught up with everyday work.
I was going to make the PR when everything would be completed but recently it appears that some Japanese people started to star my forked repository, which I think is wrong.

So, I felt we should at least merge our in-progress Japanese translation so that we can let other Japanese fellows who are willing to continue the rest (not to mention I'm still up for it whenever I can find spare time 👍 )

@yuichkun
Copy link
Author

@goldbergyoni
Hi, this is just a friendly reminder that this PR is now ready to be reviewed/merged :)

I know you may be super busy, so no rush though 👍

@jonghyo
Copy link

jonghyo commented Jan 23, 2025

@goldbergyoni @yuichkun

I created PR including all translated version that forked from
https://github.com/yuichkun/javascript-testing-best-practices/blob/master/readme-jp.md

Here is PR.
#267

@yuichkun
Copy link
Author

#267 looks good, so I'll just close this PR.
Thank you for your hardwork @jonghyo 🙏

@yuichkun yuichkun closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants