add issue reference

goldmedal · Sep 7, 2024 · 34986f9 · 34986f9
1 parent 1d923c8
commit 34986f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/datafusion/sql/src/unparser/plan.rs b/datafusion/sql/src/unparser/plan.rs
@@ -554,7 +554,8 @@ impl Unparser<'_> {
     ) -> Result<LogicalPlan> {
         match plan {
             LogicalPlan::TableScan(table_scan) => {
-                // TODO: support filters for table scan with alias
+                // TODO: support filters for table scan with alias.Remove this check after #12368 issue.
+                // see the issue: https://github.com/apache/datafusion/issues/12368
                 if alias.is_some() && !table_scan.filters.is_empty() {
                     return not_impl_err!(
                         "Subquery alias is not supported for table scan with pushdown filters"

diff --git a/datafusion/sql/tests/cases/plan_to_sql.rs b/datafusion/sql/tests/cases/plan_to_sql.rs
@@ -699,7 +699,8 @@ fn test_table_scan_pushdown() -> Result<()> {
         "SELECT * FROM t1 WHERE ((t1.id > 1) AND (t1.age < 2))"
     );
 
-    // TODO: support filters for table scan with alias
+    // TODO: support filters for table scan with alias. Enable this test after #12368 issue is fixed
+    // see the issue: https://github.com/apache/datafusion/issues/12368
     // let table_scan_with_filter_alias = table_scan_with_filters(
     //     Some("t1"),
     //     &schema,