Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New errors structure #766

Merged
merged 17 commits into from
Jan 29, 2024
Merged

New errors structure #766

merged 17 commits into from
Jan 29, 2024

Conversation

mgordel
Copy link
Contributor

@mgordel mgordel commented Jan 18, 2024

This PR contains a lot of changes in places where errors were thrown and their handling. The structure of new errors has changed according to the adopted assumptions

Added Multi-level error types thrown by individual modules.
Additionally, these errors contain useful component-specific information
@mgordel mgordel self-assigned this Jan 18, 2024
@mgordel mgordel marked this pull request as ready for review January 23, 2024 15:28
Copy link
Contributor

@SewerynKras SewerynKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, I can't promise that I tested all possible scenarios, but this looks really, really promising. I left a couple small observations

@mgordel mgordel requested a review from SewerynKras January 26, 2024 15:25
Copy link
Contributor

@SewerynKras SewerynKras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgordel mgordel merged commit ef49454 into beta Jan 29, 2024
18 checks passed
@mgordel mgordel deleted the feature/JST-660/golem-errors branch January 29, 2024 12:56
Copy link

🎉 This PR is included in version 2.0.0-beta.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants