Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/751 rpc with different routing keys #869

Conversation

vhforbes
Copy link

Hey there,

Regarding the issue: #751

I'm not experienced enough to really find the core problem so that the @RabbitRPC only listen to messages with the correct routingKeys.

Anyhow, I've wanted to propose a change so that if the routingKey is invalid, the message to be requeued so it can be picked up by the correct listener.

Any suggestions on how I can solve this in a better way are welcomed. I would do this fix only In my own code but realized it might be useful for someone else.

Thanks a lot for the lib!

@underfisk
Copy link
Contributor

Thank you @vhforbes for the contribution. In order to us to accept such behavioural change, we would need a test coverage update and possibly one more person's feedback since this will switch the behaviour.

@vhforbes
Copy link
Author

Hey @underfisk , what do mean by a test coverage update? As I can see right now there are no existing tests for the setupRpcChannel. I don't know how I can provide someone else feedback other than what's already in the issue #751, should I ask there if the change makes sense?

@vhforbes
Copy link
Author

I've just reread some RMQ docs and believe it its the intended behavior to have separate queues for different processes instead of splitting them using only routing keys. I'll close my PR since it was a misassumption but will be tuned in to improve the lib as I can!

Thanks a lot :)

@vhforbes vhforbes closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants