Handle possible unavailable conditions

golles · May 25, 2024 · 2fb9d66 · 2fb9d66
1 parent c86107c
commit 2fb9d66
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/custom_components/knmi/weather.py b/custom_components/knmi/weather.py
@@ -61,6 +61,9 @@
     "nachtbewolkt": ATTR_CONDITION_CLOUDY,
     # TODO: Check with the supplier why this is still in the response while not in the docs.
     "wolkennacht": ATTR_CONDITION_CLOUDY,
+    # Possible unavailable conditions.
+    "-": None,
+    "_": None,
 }
 
 

diff --git a/tests/test_weather.py b/tests/test_weather.py
@@ -63,10 +63,15 @@ async def test_map_conditions(hass: HomeAssistant, mocked_data, caplog):
     assert weather.map_condition("nachtmist") == ATTR_CONDITION_FOG
     assert weather.map_condition("helderenacht") == ATTR_CONDITION_CLEAR_NIGHT
     assert weather.map_condition("nachtbewolkt") == ATTR_CONDITION_CLOUDY
+    assert weather.map_condition("nachtbewolkt") == ATTR_CONDITION_CLOUDY
 
-    # # Undocumented conditions.
+    # Undocumented conditions.
     assert weather.map_condition("wolkennacht") == ATTR_CONDITION_CLOUDY
 
+    # Possible unavailable conditions.
+    assert weather.map_condition("-") == None
+    assert weather.map_condition("_") == None
+
     # Error cases.
     assert weather.map_condition(None) is None
     assert (