Handle invalid IFD #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shame on me for taking this long for a reply but if I'm not totally mistaken the latest version 0.3.6 available from npm should fix this issue. Please check your image again with this version. If it still doesn't work please attach the image causing the error to this issue so I can find a solution to the problem. |
|
Sorry for taking so long to get back to you on this. I had misplaced the image in question, but finally tracked it down today. The problem still exists as of 0.4.0. |
|
The patch is incorrect, AFAIK, there is nothing wrong with a >1000 entry IFD... |
lacombar
pushed a commit
to aerilon/node-exif
that referenced
this pull request
Feb 23, 2015
Test image provided in gomfunkel#14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
node-exifover about 6000 photos, and it got hung up on just one. In this case, it looks like the IFD was invalid, so whereas there would normally be a few IFD entires to loop over,node-exifdetected over 10000. Not exactly an infinite loop, but it effectively approximates one. This is definitely a problem with the image;exiftoolfails gracefully and reports: "Bad ExifIFD directory" when reading the same file.I was able to quickly fix this by adding a sanity check: if the number of entries exceeds 1000, something's got to be wrong so I had it bail out. There's probably a better way to solve this problem, but I figured submitting a pull request would at least be a good way to bring attention to this edge case.