Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update the flyout to account for flyout API changes in core #206

Closed
wants to merge 2 commits into from

Conversation

gonfunko
Copy link
Owner

@gonfunko gonfunko commented Oct 2, 2024

This PR updates the flyout and associated infrastructure for compatibility with the changes introduced in core Blockly in google/blockly#8601. Beyond strict compatibility, it also:

  • Registers a block inflater that supports block recycling
  • Uses icons/bubbles for blocks-with-checkboxes in the flyout so that the flyout no longer needs to be aware of or manage these. This incidentally fixes There is too much space between blocks and checkboxes in the flyout #200
  • Registers an inflater for flyout section headers with status indicators, and a corresponding class to inflate

@gonfunko gonfunko removed the request for review from rachel-fenichel October 2, 2024 18:04
@gonfunko gonfunko marked this pull request as draft October 2, 2024 18:04
@gonfunko gonfunko closed this Oct 3, 2024
@gonfunko gonfunko deleted the iflyout-inflater branch October 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is too much space between blocks and checkboxes in the flyout
2 participants