This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
Fix incorrect LatinHypercube documentation and add code for Uniform c… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
reviewed
Feb 18, 2017
distmv/general.go
Outdated
| badReceiver = "distmv: input slice is not nil or the correct length" | ||
| badSizeMismatch = "distmv: size mismatch" | ||
| badZeroDimension = "distmv: zero dimensional input" | ||
| badNonPosDimension = "distmv: non-positive dimension input" |
There was a problem hiding this comment.
I think the prefix of bad is not helpful here. This is the same issue as badSizeMismatch. nonPositiveDimension seems more meaningful.
There was a problem hiding this comment.
Sorry, I thought that we were using bad as a generic panic prefix. I guess I misunderstood the previous suggestion.
There was a problem hiding this comment.
"bad" just means that, that the thing was bad without necessarily saying why. So "badSizeMismatch" would either be "badSize" or preferably "sizeMismatch" (since that is the message). The same argument holds here.
distmv/uniform.go
Outdated
| @@ -44,6 +44,22 @@ func NewUniform(bnds []Bound, src *rand.Source) *Uniform { | |||
| return u | |||
| } | |||
|
|
|||
| func NewUnitUniform(dim int, src *rand.Source) *Uniform { | |||
distuv/uniform.go
Outdated
| @@ -9,6 +9,8 @@ import ( | |||
| "math/rand" | |||
| ) | |||
|
|
|||
| var UnitUniform = Uniform{Min: 0, Max: 1} | |||
kortschak
approved these changes
Feb 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onvenience