New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mjcf schema #380

Open

hartikainen wants to merge 4 commits into google-deepmind:main from hartikainen:update-mjcf-schema

Contributor

hartikainen commented Feb 16, 2023

I noticed some differences between the mjcf xml schema and the documentation's XML Reference. This fixes two of these differences:

sensor/user element's attribute defaults. The corresponding change to mujoco was made in google-deepmind/mujoco@221c63d.
size element's memory attribute. I believe the corrensponding change to mujoco was made in google-deepmind/mujoco@58fd72f.

Also adds two test cases through test_model.xml, which both fail without these schema changes.

hartikainen added 4 commits

February 16, 2023 11:32


          Update sensor/user attribute restrictions

0e56598


          Add test for user/sensor without optional fields

bb52f8c


          Add memory attribute to size element

6770d2f


          Add test for size element's memory attribute

8e0f811

yuvaltassa approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet