Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Fix docker development installation #39

Open
wants to merge 3 commits into
base: r0.5.2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ container should support. The command below enables support for Python
3.7, 3.8, 3.9 and 3.10.
```
$ docker build --tag launchpad:devel \
--build-arg tensorflow_pip=tensorflow==2.3.0 \
--build-arg tensorflow_pip="tensorflow==2.9.*" \
--build-arg python_version="3.7 3.8 3.9 3.10" - < docker/build.dockerfile
```

Expand All @@ -132,7 +132,7 @@ $ docker run --rm --mount "type=bind,src=$PWD,dst=/tmp/launchpad" \
At this point you can build and install Launchpad within the container by
executing:
```
$ /tmp/launchpad/oss_build.sh
$ /tmp/launchpad/oss_build.sh --tf_package "tensorflow==2.9.*" --reverb_package "dm-reverb==0.7.2"
```

By default it builds Python 3.8 version, you can change that with `--python`
Expand Down
5 changes: 4 additions & 1 deletion docker/build.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ ARG APT_COMMAND="apt-get -o Acquire::Retries=3 -y"
ARG DEBIAN_FRONTEND=noninteractive
ENV TZ=America/Los_Angeles

RUN rm /etc/apt/sources.list.d/cuda.list
RUN rm /etc/apt/sources.list.d/nvidia-ml.list

# Pick up some TF dependencies
RUN ${APT_COMMAND} update && ${APT_COMMAND} install -y --no-install-recommends \
software-properties-common \
Expand All @@ -25,7 +28,7 @@ RUN ${APT_COMMAND} update && ${APT_COMMAND} install -y --no-install-recommends \
libzmq3-dev \
lsof \
pkg-config \
python3.7-dev \
python3-dev \
python3.8-dev \
python3.9-dev \
python3.10-dev \
Expand Down
2 changes: 1 addition & 1 deletion oss_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cd "$(dirname "$0")"
# Flags
PYTHON_VERSIONS=3.8 # Options 3.7, 3.8, 3.9, 3.10
CLEAN=false # Set to true to run bazel clean.
OUTPUT_DIR=/tmp/launchpad/dist/
OUTPUT_DIR=/tmp/launchpad/dist
INSTALL=true # Should the built package be installed.

PIP_PKG_EXTRA_ARGS="" # Extra args passed to `build_pip_package`.
Expand Down