Build fix for v0.6.0 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanluoyc
commented
Aug 9, 2023
| @@ -235,14 +235,14 @@ cc_library( | |||
|
|
|||
| def _python_includes_repo_impl(repo_ctx): | |||
| python_include_path = _find_python_include_path(repo_ctx) | |||
| python_solib = _find_python_solib_path(repo_ctx) | |||
There was a problem hiding this comment.
This is based on the google-deepmind/reverb#106 I did for Reverb. It's not necessary to include the .so and that actually causes troubles for some Python environments that do not install libpython.so at the system location (aka conda).
I can clean this up if tests pass.
The current build is problematic when building for multiple python versions. See google-deepmind/reverb@4da8a91
|
Any update on this? I'm happy to help e.g. testing this if that's useful. |
|
@hartikainen You can use these wheels for your requirements.txt like |
|
@ethanluoyc This is very useful, thanks! I had some issues building it myself - any chance you could do a quick python 3.12 wheel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41.
I tested this on my machine for Python 3.9 and 3.10. This seems to work fine. Some of the workaround for my previous fork no longer seems necessary.
@ddmbr can you help run the internal checks and see if it works. If so, I suppose we can release lp v0.6 and I can update my projects to use Launchpad from PyPI.
Also @hartikainen