Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TIAGo and TIAGo++ Robot from PAL Robotics #19

Open
saikishor opened this issue Jul 26, 2023 · 10 comments · May be fixed by #94
Open

Add TIAGo and TIAGo++ Robot from PAL Robotics #19

saikishor opened this issue Jul 26, 2023 · 10 comments · May be fixed by #94
Assignees
Labels
new-model New model request

Comments

@saikishor
Copy link
Contributor

URL for the existing model source (e.g. URDF)

TIAGo URDF : https://github.com/pal-robotics/tiago_robot/tree/kinetic-devel/tiago_description/robots
TIAGo++ URDF: https://github.com/pal-robotics/tiago_dual_robot/tree/kinetic-devel/tiago_dual_description/robots

License terms of the upstream model

Both TIAGo and TIAGo++ will be with Apache License 2.0

What do you think is required to convert and tune this model for MuJoCo?

  • Being able to convert from the URDF to MuJoCo using the compile command
  • We need to add the actuators to the model for better joint actuation
  • Stability of the model w.r.t to the actuator's gain tuning
  • Taking into account the existing issue with the repeated naming in the MuJoCo

Are you proposing to help develop and maintain the new model?

Yes, we can develop and help maintain the new model. It is in our interest as a part of the @pal-robotics team.

@saikishor
Copy link
Contributor Author

Hello!

Can we open a PR on this from our end?

Thank you,

Best Regards,
Sai

@kevinzakka
Copy link
Collaborator

@saikishor Yes, please go ahead!

@saikishor
Copy link
Contributor Author

Hello @kevinzakka!

Thank you for the prompt response to my earlier message. I've opened a PR adding our Robots.

Thank you,

Best Regards,
Sai

@kevinzakka
Copy link
Collaborator

Cool, thanks for making the PR. Working on integrating on my end!

@saikishor
Copy link
Contributor Author

Hello @kevinzakka!

Thank you for your imminent response. Looking forward to seeing them in the main branch soon. If you have any queries or need any changes, please feel free to get back to us.

Thank you,

Best Regards,
Sai

@kevinzakka
Copy link
Collaborator

Hi @saikishor, noticing weird behavior with the robot fingers. Have those been carefully looked at?

@saikishor
Copy link
Contributor Author

Hello @kevinzakka!

I just checked it. Unfortunately, we missed that detail. The mistake is on our end. I'm sorry about that.

https://github.com/pal-robotics-forks/mujoco_menagerie/blob/140ae8d30b430d9d8d8f0c42e031b93b59cb2968/pal_tiago/tiago.xml#L239-L245

I think the gains for those joints need to be tweaked. Tomorrow, we will try to fix that. Thank you for reporting it.

Do you have any other feedback?

Thank you,

Best Regards,
Sai Kishor Kothakota

@saikishor
Copy link
Contributor Author

Hey @kevinzakka!

Thank you for reporting the issues. We have pushed some new changes to the PR. Whenever you get some time, please kindly try it and let us know.

Thank you,

Best Regards,
Sai

@kevinzakka
Copy link
Collaborator

Thanks @saikishor! I'm wrapping up another robot submission. Once that's done, I can get your PR reviewed and merged in. Thanks for being patient.

@saikishor
Copy link
Contributor Author

Thank you so much @kevinzakka.

@kevinzakka kevinzakka added the new-model New model request label Oct 11, 2023
@kevinzakka kevinzakka self-assigned this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model New model request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants