Simplify the APIs for simulation_output_to_xr() and write_simulation_output_to_file().
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@allen-adastra - fyi, this changes the API of the function you introduced. Doing this to simplify some other code we are writing which uses TORAX. |
copybara-service
bot
force-pushed
the
test_623473383
branch
3 times, most recently
from
243da71
to
18d4ed9
Compare
…on_output_to_file()`. There was a lot of copied code when trying to use `sim.run()` directly without using `simulation_app.main()`. This reduces that. PiperOrigin-RevId: 624116183
copybara-service
bot
force-pushed
the
test_623473383
branch
from
18d4ed9
to
b9dfce9
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
b9dfce9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the APIs for
simulation_output_to_xr()andwrite_simulation_output_to_file().There was a lot of copied code when trying to use
sim.run()directly without usingsimulation_app.main(). This reduces that.