feat: implement general build_geometry #40
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| ) -> CHEASEGeometry: | ||
| """Build geometry object based on set of profiles from an EQ solution. | ||
|
|
||
| Expects the quantities to adhere to COCOS=??. All inputs are 1D profiles vs normalized rho toroidal (rhon). |
There was a problem hiding this comment.
Should pick a COCOS variant here and then maybe even cross-check as much as possible that the inputs adhere to that.
| # Set the CHEASE geometry-specific parameters. | ||
| g2=g2, | ||
| g3=g3, | ||
| psi_chease=psi_chease, |
There was a problem hiding this comment.
psi_chease doesn't seem to be used anywhere. Removing it would mean one could avoid having to pass psi as input.
| Rin: jnp.ndarray, | ||
| Rout: jnp.ndarray, | ||
| RBPhi: jnp.ndarray, | ||
| int_Jdchi: jnp.ndarray, |
There was a problem hiding this comment.
Should we consider dV_dpsi as a maybe more recognizable name for this quantity?
…tor calcuation based on meq output
We can use to
build_geometryto call torax with MEQ output.But I envision it can be a general entry point for various EQ codes.
TODO:
build_geometryshould assume as input.