Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response.text and response.data #344

Merged
merged 18 commits into from
Dec 17, 2024
Merged

Conversation

MarkDaoust
Copy link
Contributor

@MarkDaoust MarkDaoust commented Dec 12, 2024

Use response.text and response.data

Also:

live_api_starter.ipynb

  • Use enumerate instead of first
  • Give option to pass turns= when creating the autio loop so it can run without interaction.

live_api_starter.py

websockets/live_api_starter.py

  • Use a single oputput message queue
  • Cleanup the exception handling

README.md

  • Mention video out.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MarkDaoust MarkDaoust marked this pull request as draft December 12, 2024 12:44
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Dec 12, 2024
Copy link

review-notebook-app bot commented Dec 12, 2024

View / edit / reply to this conversation on ReviewNB

Giom-V commented on 2024-12-12T14:50:12Z
----------------------------------------------------------------

Line #15.    async def aenumerate(it):

Typo? It not maybe you should name it differently?


MarkDaoust commented on 2024-12-12T22:37:26Z
----------------------------------------------------------------

Any suggestions? async_enumerate?

Giom-V commented on 2024-12-15T12:59:35Z
----------------------------------------------------------------

I think it would be clearer yes.

Copy link
Contributor Author

Any suggestions? async_enumerate?


View entire conversation on ReviewNB

@MarkDaoust MarkDaoust changed the title Updates Use response.text and response.data Dec 12, 2024
@MarkDaoust MarkDaoust requested a review from Giom-V December 13, 2024 01:09
@MarkDaoust MarkDaoust marked this pull request as ready for review December 13, 2024 01:10
@MarkDaoust MarkDaoust requested a review from markmcd December 13, 2024 17:35
markmcd
markmcd previously approved these changes Dec 14, 2024
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Giom-V
Giom-V previously approved these changes Dec 15, 2024
Copy link
Collaborator

Giom-V commented Dec 15, 2024

I think it would be clearer yes.


View entire conversation on ReviewNB

Copy link
Contributor Author

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for #353.

@MarkDaoust MarkDaoust dismissed stale reviews from Giom-V and markmcd via 97f71b1 December 16, 2024 17:55
@Giom-V Giom-V merged commit 97c0998 into google-gemini:main Dec 17, 2024
4 checks passed
Copy link

@iqbalbhatti49 iqbalbhatti49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants