Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploadBlob method to GoogleAIFileManager. #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thorwebdev
Copy link

Fixes #221

Allow more flexibility for uploading files.

My preferred API would have been this:

async uploadFile({
    filePath,
    blob,
    fileMetadata,
  }: {
    filePath?: string;
    blob?: BlobPart;
    fileMetadata: FileMetadata;
  }): Promise<UploadFileResponse>

But since uploadFile currently doesn't take an object, this would be a breaking change. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update uploadFile method to accept buffer
1 participant