Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make system instruction accept variadic String... #155

Merged
merged 2 commits into from
May 1, 2024
Merged

Make system instruction accept variadic String... #155

merged 2 commits into from
May 1, 2024

Conversation

andrewheard
Copy link
Collaborator

Updated the GenerativeModel constructor taking systemInstruction: String (from #152) to accept a variadic String.... The Gemini 1.5 model supports multiple text-only system instructions.

paulb777
paulb777 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please add an API test for multiple strings passed

@andrewheard andrewheard marked this pull request as ready for review April 30, 2024 21:49
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Apr 30, 2024
@andrewheard
Copy link
Collaborator Author

As discussed, please add an API test for multiple strings passed

@paulb777 Done.

@andrewheard andrewheard merged commit 16e68be into main May 1, 2024
9 checks passed
@andrewheard andrewheard deleted the ah/sys-instruc-variadic branch May 1, 2024 21:32
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 1, 2024
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
@andrewheard
Make system instruction accept variadic String... (google-gemini#155)
a8d05ef
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
@andrewheard
Make system instruction accept variadic String... (google-gemini#155)
1401265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777