Make SafetyRating conform to Hashable
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:swift sdk
paulb777
approved these changes
Dec 12, 2023
|
Thanks, @andrewheard! |
ryanwilson
approved these changes
Dec 12, 2023
github-actions
bot
removed
the
status:awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows collections of
SafetyRatings to be displayed in SwiftUI views, such asList, which require the elements to conform toHashable.Note: When moved into the SDK, the auto-synthesized
Hashableconformance can be used (SE-0185). This wasn't possible when conformance was implemented in the sample app (Extension outside of file declaring struct 'SafetyRating' prevents automatic synthesis of 'hash(into:)' for protocol 'Hashable').