-
Notifications
You must be signed in to change notification settings - Fork 529
fix(audiocontext): works on both Safari and Chrome #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: dselman <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Yes, this is now broken on Chrome... More investigation needed. |
Interesting thread: https://stackoverflow.com/a/74495761 |
Signed-off-by: dselman <[email protected]>
Signed-off-by: dselman <[email protected]>
Signed-off-by: dselman <[email protected]>
Signed-off-by: dselman <[email protected]>
Signed-off-by: dselman <[email protected]>
I tested in Chrome and Safari, it works as expected. |
did you test it on ios? |
existing audiocontext does not work on safari on ios. it also does not work on chrome on ios sometimes. audiocontext is getting suspended. [Log] Creating new AudioStreamer... another instance another instance [Log] Found back camera: – "Back Camera" |
Yes, it works on Iphone iOS safari. |
I tested on Safari and Chrome from an iPhone as well and I have the following findings:
|
Thanks this helped me fix 2 of the 3 the audio issues! Only remaining issue is that the user always has to give permission even after they already gave permission. But I think this is an iOS thing. |
Fix for issue: #21
I'm not sure why the original code was so complex, but this simplified version seems to work on both Safari and Chrome on Mac OS.