Full pytorch support #145
Full pytorch support #145
Conversation
| """TimesFM init file.""" | ||
|
|
||
| from .timesfm import TimesFm, freq_map |
There was a problem hiding this comment.
I was wondering if we should print / log the API change here, just in case people forget to check the new README.
There was a problem hiding this comment.
Oh thats a good idea. What should be log here ?
There was a problem hiding this comment.
What about
print("TimesFM v1.2.0. See https://github.com/google-research/timesfm/blob/master/README.md for updated APIs.")
There was a problem hiding this comment.
Done, will leave the version upload to you.
| """TimesFM init file.""" | ||
|
|
||
| from .timesfm import TimesFm, freq_map | ||
| from timesfm.timesfm_base import freq_map, TimesFmCheckpoint, TimesFmHparams, TimesFmBase | ||
| try: |
There was a problem hiding this comment.
I am thinking what if one has both jax and torch version installed.
There was a problem hiding this comment.
I think in that case the JAX version will be initialized as TimesFM.
There was a problem hiding this comment.
Sg. Let's add
print("Loaded Jax TimesFM.")
and
print("Loaded PyTorch TimesFM.")
after the imports respectively.
|
LGTM. |
No description provided.