Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-std switch to verilator #783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PiotrZierhoffer
Copy link
Collaborator

@tcal-x can you please verify if this fixes the problem for you?

Signed-off-by: Piotr Zierhoffer <[email protected]>
@tcal-x
Copy link
Collaborator

tcal-x commented Feb 24, 2023

Hi @PiotrZierhoffer , thanks! --- that did fix the issue I saw running "make renode" manually, but there are many failing tests now?

@PiotrZierhoffer
Copy link
Collaborator Author

It stems from the fact that the CI uses older verilator.

Let's [WIP] this - we'll change the package to implicitly provide this switch, so that the user interface doesn't change.

@tcal-x
Copy link
Collaborator

tcal-x commented Feb 27, 2023

If I recall correctly, we originally added Verilator to the list of Conda packages used because the version that we got from sudo apt install verilator in Google Colab (Ubuntu 18) was too old.

I thought all of the Github Actions now relied on the Conda packages, which should hide an older system version of Verilator?

@PiotrZierhoffer
Copy link
Collaborator Author

We made some changes to the verilator conda package, as it was failing the build on GCP.

We need to update it a little bit further to address this use case, I believe.

@tcal-x
Copy link
Collaborator

tcal-x commented Apr 26, 2023

@PiotrZierhoffer sorry if I dropped the ball here -- what is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants