Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Refactor out clock utils #130

Merged
merged 2 commits into from
May 22, 2024
Merged

[Infra] Refactor out clock utils #130

merged 2 commits into from
May 22, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 21, 2024

No description provided.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleDataTransport-ios-GoogleDataTransport.framework

    Overall coverage changed from 58.02% (23fb0d9) to 44.18% (fc9005b) by -13.84%.

    29 individual files with coverage change

    FilenameBase (23fb0d9)Merge (fc9005b)Diff
    GDTCCTCompressionHelper.m0.00%81.63%+81.63%
    GDTCCTNanopbHelpers.m0.00%56.04%+56.04%
    GDTCCTUploader.m20.26%89.54%+69.28%
    GDTCCTUploadOperation.m0.00%91.04%+91.04%
    GDTCORAssert.m88.24%0.00%-88.24%
    GDTCORClock.m86.21%64.62%-21.59%
    GDTCORClockUtils.m?90.91%?
    GDTCORConsoleLogger.m74.07%18.52%-55.56%
    GDTCORDirectorySizeTracker.m93.10%63.79%-29.31%
    GDTCOREndpoints.m100.00%0.00%-100.00%
    GDTCOREvent+GDTCCTSupport.m0.00%35.42%+35.42%
    GDTCOREvent+GDTMetricsSupport.m0.00%100.00%+100.00%
    GDTCOREvent.m97.75%61.80%-35.96%
    GDTCORFlatFileStorage+Promises.m27.75%0.00%-27.75%
    GDTCORFlatFileStorage.m91.01%13.44%-77.57%
    GDTCORLifecycle.m55.56%40.74%-14.81%
    GDTCORLogSourceMetrics.m93.91%52.17%-41.74%
    GDTCORMetrics+GDTCCTSupport.m0.00%95.24%+95.24%
    GDTCORMetrics.m40.00%47.27%+7.27%
    GDTCORMetricsController.m94.77%16.28%-78.49%
    GDTCORMetricsMetadata.m100.00%0.00%-100.00%
    GDTCORPlatform.m64.40%51.36%-13.04%
    GDTCORProductData.m84.21%42.11%-42.11%
    GDTCORRegistrar.m74.60%76.72%+2.12%
    GDTCORStorageMetadata.m100.00%0.00%-100.00%
    GDTCORTransformer.m91.26%0.00%-91.26%
    GDTCORTransport.m86.67%0.00%-86.67%
    GDTCORUploadBatch.m0.00%100.00%+100.00%
    GDTCORUploadCoordinator.m79.87%59.74%-20.13%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MT88q5FdO5.html

@ncooke3 ncooke3 marked this pull request as ready for review May 21, 2024 17:52
@ncooke3 ncooke3 merged commit b7bd781 into main May 22, 2024
21 checks passed
@ncooke3 ncooke3 deleted the nc/third-party branch May 22, 2024 19:15
ncooke3 added a commit that referenced this pull request Jun 4, 2024
@ncooke3
Revert "[Infra] Refactor out clock utils (#130)"
6fafda5 
This reverts commit b7bd781.
ncooke3 added a commit that referenced this pull request Jun 5, 2024
@ncooke3
[Infra] Refactor recent third_party refactors (#134)
e6d2576 
* Revert "[NFC] Prefer <dispatch/dispatch.h> over <dispatch/time.h> (#131)"

This reverts commit d4932cd.

* Revert "[Infra] Refactor out clock utils (#130)"

This reverts commit b7bd781.

* [Infra] Refactor recent third_party refactors
ncooke3 added a commit that referenced this pull request Jun 5, 2024
@ncooke3
[Infra] Refactor recent third_party refactors (#134) (#135)
4df4854 
* Revert "[NFC] Prefer <dispatch/dispatch.h> over <dispatch/time.h> (#131)"

This reverts commit d4932cd.

* Revert "[Infra] Refactor out clock utils (#130)"

This reverts commit b7bd781.

* [Infra] Refactor recent third_party refactors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777