Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add analyze to ci #155

Merged
merged 3 commits into from
Dec 28, 2024
Merged

add analyze to ci #155

merged 3 commits into from
Dec 28, 2024

Conversation

morganchen12
Copy link
Collaborator

The flagged line in firebase/quickstart-ios#1595 doesn't seem to be a valid issue, but we should still be running static analyzer in CI.

@google-oss-bot
Copy link

google-oss-bot commented Dec 27, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • GoogleDataTransport-ios-GoogleDataTransport.framework

    Overall coverage changed from 62.83% (43b992a) to 45.26% (7e534bc) by -17.57%.

    29 individual files with coverage change

    FilenameBase (43b992a)Merge (7e534bc)Diff
    GDTCCTCompressionHelper.m0.00%81.63%+81.63%
    GDTCCTNanopbHelpers.m0.00%56.04%+56.04%
    GDTCCTUploader.m54.25%89.54%+35.29%
    GDTCCTUploadOperation.m28.49%90.93%+62.43%
    GDTCCTURLSessionDataResponse.m0.00%100.00%+100.00%
    GDTCORAssert.m88.24%0.00%-88.24%
    GDTCORClock.m86.21%71.26%-14.94%
    GDTCORConsoleLogger.m74.07%18.52%-55.56%
    GDTCORDirectorySizeTracker.m93.10%63.79%-29.31%
    GDTCOREndpoints.m100.00%0.00%-100.00%
    GDTCOREvent+GDTCCTSupport.m0.00%35.05%+35.05%
    GDTCOREvent+GDTMetricsSupport.m0.00%75.00%+75.00%
    GDTCOREvent.m88.76%61.80%-26.97%
    GDTCORFlatFileStorage+Promises.m46.29%0.00%-46.29%
    GDTCORFlatFileStorage.m91.01%13.44%-77.57%
    GDTCORLifecycle.m55.56%40.74%-14.81%
    GDTCORLogSourceMetrics.m94.78%52.17%-42.61%
    GDTCORMetrics+GDTCCTSupport.m0.00%93.75%+93.75%
    GDTCORMetrics.m30.91%47.27%+16.36%
    GDTCORMetricsController.m94.77%16.28%-78.49%
    GDTCORMetricsMetadata.m100.00%0.00%-100.00%
    GDTCORPlatform.m71.84%59.18%-12.66%
    GDTCORProductData.m84.21%42.11%-42.11%
    GDTCORRegistrar.m79.37%76.72%-2.65%
    GDTCORStorageMetadata.m100.00%0.00%-100.00%
    GDTCORTransformer.m91.26%0.00%-91.26%
    GDTCORTransport.m81.25%0.00%-81.25%
    GDTCORUploadBatch.m0.00%100.00%+100.00%
    GDTCORUploadCoordinator.m79.87%59.74%-20.13%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KW8DnXyQg6.html

@paulb777
Copy link
Member

Oh sorry. analyze is already the default in the pod_lib_lint script, so it is being run. https://github.com/firebase/firebase-ios-sdk/blob/main/scripts/pod_lib_lint.rb#L56

@morganchen12 morganchen12 merged commit c6afba6 into main Dec 28, 2024
21 checks passed
@morganchen12 morganchen12 deleted the mc/sign branch December 28, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganchen12 @google-oss-bot @paulb777