Implement methods to create the default options for the verify flow. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
requested changes
Apr 2, 2024
…hub.com/google/GoogleSignIn-iOS into briannamorales/GIDSignInInternalOptions
mdmathias
requested changes
Apr 5, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Show resolved
Hide resolved
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
mdmathias
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify GIDSignInInternalOptions to include two new methods creating default options for the verification flow. The methods will create default options depending on whether an
accountDetailsToVerifyarray was passed into it. Additionally a new completion block is created,GIDVerifyCompletion, to help fill the completion field with either aGIDVerifiedAccountDetailResultobject or an error.Methods added:
-[GIDSignInInternalOptions defaultOptionsWithConfiguration:presentingViewController:loginHint:addScopesFlow:verifyCompletion:]-[GIDSignInInternalOptions defaultOptionsWithConfiguration:presentingViewController:loginHint:addScopesFlow:accountDetailsToVerify:verifyCompletion:]