-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VwG] Add verification flow example to DaysUntilBirthday Sample App. #452
Merged
brnnmrls
merged 9 commits into
briannamorales/vwg-flow
from
briannamorales/verifyFlowExample
Jul 16, 2024
Merged
[VwG] Add verification flow example to DaysUntilBirthday Sample App. #452
brnnmrls
merged 9 commits into
briannamorales/vwg-flow
from
briannamorales/verifyFlowExample
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
requested changes
Jul 9, 2024
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Services/GoogleSignInAuthenticator.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/AuthenticationViewModel.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Views/VerificationView.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Views/VerificationView.swift
Outdated
Show resolved
Hide resolved
mdmathias
requested changes
Jul 10, 2024
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/DaysUntilBirthdayForPod.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Services/VerificationLoader.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Services/VerificationLoader.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/Services/VerificationLoader.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/VerifiedAgeViewModel.swift
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/VerifiedAgeViewModel.swift
Outdated
Show resolved
Hide resolved
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/VerifiedAgeViewModel.swift
Outdated
Show resolved
Hide resolved
mdmathias
reviewed
Jul 12, 2024
Samples/Swift/DaysUntilBirthday/Shared/ViewModels/VerifiedAgeViewModel.swift
Outdated
Show resolved
Hide resolved
mdmathias
reviewed
Jul 12, 2024
Samples/Swift/DaysUntilBirthday/Shared/Services/VerificationLoader.swift
Outdated
Show resolved
Hide resolved
…d update method names.
mdmathias
requested changes
Jul 16, 2024
Samples/Swift/DaysUntilBirthday/Shared/Services/VerificationLoader.swift
Outdated
Show resolved
Hide resolved
mdmathias
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please make sure the integration tests pass prior to merging. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes add the VwG flow to the DaysUntilBirthday Sample App. Once the user clicks 'Verify My Age' on the UserProfileView and navigates to VerificationView. The verify flow commences and either returns a token response or an error. If there's a returned token response, then the VerificationView prints that it's a verified account along with details of the refresh and access tokens. If an error is returned, then the VerificationView displays "Unverified Account" along with a loading icon.
The refresh feature and exercising the tokens will be sent out in separate PRs.