Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change macos runner to 13. #482

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,16 @@ jobs:
-sdk iphonesimulator \
-destination 'platform=iOS Simulator,name=iPhone 15,OS=17.4' \
EMAIL_SECRET=$EMAIL_SECRET \
PASSWORD_SECRET=$PASSWORD_SECRET
PASSWORD_SECRET=$PASSWORD_SECRET \
-resultBundlePath DaysUntilBirthday.xcresult test
- name: Wait for xcresult file
run: sleep 30
- name: Upload xcresult file
uses: actions/upload-artifact@v4
if: ${{ always() }}
with:
name: DaysUntilBirthday-${{ github.run_number }}.xcresult
path: DaysUntilBirthday.xcresult

app-check-api-token-tests:
runs-on: macOS-13
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- sdk: 'macosx'
destination: '"platform=OS X,arch=x86_64"'
- sdk: 'iphonesimulator'
destination: '"platform=iOS Simulator,name=iPhone 14"'
destination: '"platform=iOS Simulator,name=iPhone 15"'
steps:
- uses: actions/checkout@v3
- name: Build unit test target
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ extension DaysUntilBirthdayUITests_iOS {
return false
}
guard sampleApp.staticTexts["User Profile"]
.waitForExistence(timeout: timeout) else {
.waitForExistence(timeout: 30) else {
XCTFail("Failed to sign in and return to app's User Profile view.")
return false
}
Expand All @@ -124,11 +124,13 @@ extension DaysUntilBirthdayUITests_iOS {
/// This will assumme the full flow where a user must type in an email and
/// password to sign in with.
func signInForTheFirstTime() -> Bool {
print("BOO: it's the first time")
guard sampleApp.textFields["Email or phone"]
.waitForExistence(timeout: timeout) else {
.waitForExistence(timeout: 30) else {
XCTFail("Failed to find email textfield")
return false
}
print("BOO: before the return button")
guard sampleApp
.keyboards
.element
Expand All @@ -137,15 +139,17 @@ extension DaysUntilBirthdayUITests_iOS {
XCTFail("Failed to find 'return' button")
return false
}

print("BOO: before typing in email or phone text")
sampleApp.textFields["Email or phone"].typeText(Credential.email.rawValue)
print("BOO: before tapping on return for email or phone")
sampleApp.keyboards.element.buttons["return"].tap()

print("BOO: before entering password")
guard sampleApp.secureTextFields["Enter your password"]
.waitForExistence(timeout: timeout) else {
XCTFail("Failed to find password textfield")
return false
}
print("BOO: before checking existence of return for password")
guard sampleApp
.keyboards
.element
Expand All @@ -154,12 +158,12 @@ extension DaysUntilBirthdayUITests_iOS {
XCTFail("Failed to find 'return' button")
return false
}

print("BOO: before entering return on password")
sampleApp
.secureTextFields["Enter your password"]
.typeText(Credential.password.rawValue)
sampleApp.keyboards.element.buttons["return"].tap()

print("BOO: before password manager prompt existence")
if sampleApp
.staticTexts[passwordManagerPrompt]
.waitForExistence(timeout: timeout) {
Expand All @@ -169,7 +173,9 @@ extension DaysUntilBirthdayUITests_iOS {
XCTFail("Failed to find \(notNowText) button")
return false
}
print("BOO: before not now text tap")
sampleApp.buttons[notNowText].tap()
print("BOO: after not now text tap")
}

// Proceed through sign-in disclaimer and/or access request view(s) if needed
Expand Down
Loading