-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a high level persistent storage API #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check in details, but for the change to be backward compatible, we need to use the same keys and encode the values the same way. From what I've seen so far it seems like it, but just making sure it's conscious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the testing strategy?
Co-authored-by: Julien Cretin <[email protected]>
I flashed the PR on hardware, then went through the following tests, mostly storage related:
Then deploy |
Changes the store API to a wider API for data in a persistant way. Joins the attestation store into the regular store, and allows more control over how to special case some of the storage.
The
KeyStore
had some persistent elements that were moved out, and the crypto-related parts were kept separately.In some cases, we can consider unifying even more, like the way the PIN hash is stored. To keep the PR smaller, it only implements the general API changes, no updates to specific parts of the API when not necessary.
One planned follow-up is LargeBlob (see the TODO comment).