Skip to content

fix: Handle App objects in eval and graph endpoints #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Handle App objects in eval and graph endpoints #3060

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ff113c
fix: Handle App objects in eval and graph endpoints
ejfn Oct 1, 2025
d058a95
refactor: Extract _get_root_agent helper method
ejfn Oct 1, 2025
e4e78e0
Merge branch 'main' into ejfn/bugfix-app-object-endpoints
ejfn Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/google/adk/cli/adk_web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,12 @@ async def get_runner_async(self, app_name: str) -> Runner:
self.runner_dict[app_name] = runner
return runner

def _get_root_agent(self, agent_or_app: BaseAgent | App) -> BaseAgent:
"""Extract root agent from either a BaseAgent or App object."""
if isinstance(agent_or_app, App):
return agent_or_app.root_agent
return agent_or_app

def _create_runner(self, agentic_app: App) -> Runner:
"""Create a runner with common services."""
return Runner(
Expand Down Expand Up @@ -803,9 +809,8 @@ async def add_session_to_eval_set(

# Populate the session with initial session state.
agent_or_app = self.agent_loader.load_agent(app_name)
if isinstance(agent_or_app, App):
agent_or_app = agent_or_app.root_agent
initial_session_state = create_empty_state(agent_or_app)
root_agent = self._get_root_agent(agent_or_app)
initial_session_state = create_empty_state(root_agent)

new_eval_case = EvalCase(
eval_id=req.eval_id,
Expand Down Expand Up @@ -966,7 +971,8 @@ async def run_eval(
status_code=400, detail=f"Eval set `{eval_set_id}` not found."
)

root_agent = self.agent_loader.load_agent(app_name)
agent_or_app = self.agent_loader.load_agent(app_name)
root_agent = self._get_root_agent(agent_or_app)

eval_case_results = []

Expand Down Expand Up @@ -1305,7 +1311,8 @@ async def get_event_graph(

function_calls = event.get_function_calls()
function_responses = event.get_function_responses()
root_agent = self.agent_loader.load_agent(app_name)
agent_or_app = self.agent_loader.load_agent(app_name)
root_agent = self._get_root_agent(agent_or_app)
dot_graph = None
if function_calls:
function_call_highlights = []
Expand Down