Fix deploy to cloud run on Windows

[anrzeszutek]

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Closes: Gcloud file not being found in Windows Installing while using adk deploy #1597
• Related: Main Issue: ADK Windows platform issues #3306

Problem:
After running adk deploy cloud_run on Windows, error occurres: [WinError 2] The system cannot find the file specified

Solution:
On Windows we need to pass the whole script name -> gcloud.cmd for subprocess.run to find and execute it.

Testing Plan

I run unit tests and I managed to successfully deploy to cloud run on Windows platform.

Unit Tests:

• I have added or updated unit tests for my change.
• All unit tests pass locally. - I had some errors with collecting tests, but all tests connected to my change pass locally

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

This screenshot shows logs confirming that the default project was correctly obtained. It was also affected by this issue.

[gemini-code-assist]

Summary of Changes

Hello @anrzeszutek, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue that prevented Cloud Run deployments from Windows environments by correctly handling the invocation of the gcloud command. By adapting the command execution to Windows' specific requirements, it resolves the 'file not found' error, ensuring that users on Windows can seamlessly deploy their applications to Cloud Run.

Highlights

• Windows Compatibility Fix: This pull request resolves a [WinError 2] encountered when attempting to deploy to Cloud Run from a Windows environment using adk deploy cloud_run.
• Gcloud Command Invocation: The fix involves explicitly specifying gcloud.cmd instead of just gcloud when executing subprocess.run commands on Windows, allowing the system to correctly locate and execute the gcloud CLI.
• Operating System Detection: A new IS_WINDOWS constant has been introduced to conditionally apply the Windows-specific gcloud.cmd invocation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @anrzeszutek, thank you for your contribution!

To help reviewers verify the fix, could you please provide a screenshot or console output showing the adk deploy cloud_run command running successfully on Windows after your changes?

You can find more details in our contribution guidelines. Thanks!

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue with deploying to Cloud Run on Windows by using gcloud.cmd. The change is effective and the tests are updated accordingly. My main feedback is about code duplication. The logic to determine the gcloud command based on the operating system is repeated in src/google/adk/cli/cli_deploy.py (in two different functions) and in the test file. I've added comments suggesting a refactoring to use a single constant for the command name. This will make the code more maintainable and less redundant. Overall, this is a good fix that just needs a small refactoring.

[Jacksunwei]

@DeanChensj could you help review this one?

[adk-bot]

Thank you @anrzeszutek for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 29fea7e.

Closing this PR as the changes are now in the main branch.