Skip to content

fix: format by pyink on database_session_service.py #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anencore94
Copy link

Fix failed pyink format on current main branch by uv run pyink --config pyproject.toml ./src

anencore94 added 3 commits May 6, 2025 16:38
- apply pyink, reformat automatically
@hangfei
Copy link
Collaborator

hangfei commented May 8, 2025

we are using two-space. is there special rule for this case?

@anencore94
Copy link
Author

we are using two-space. is there special rule for this case?

Thx for your reply :) @hangfei
I'm not sure what is the intended convention, but as following from the CONTRIBUTING.md, pyink automaticallly format that file as four spaces for ValueError wrapping.

image

Maybe it depends on the version of pyink or python? if it doesn't raise an issue in workflow?

However, as I see the other code lines, use four spaces when we raise some Error class
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants