Skip to content

fix: fix failed unit tests in test_integration_client.py #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

luaifei
Copy link
Contributor

@luaifei luaifei commented May 8, 2025

Change Scope

Fix the failed unit tests in the test_integration_client.py.

Root cause

The integration_client.py constructor has broken change recently, the field changes from trigger: Optional[str] to triggers: List.

@hangfei hangfei self-requested a review May 8, 2025 03:19
@hangfei
Copy link
Collaborator

hangfei commented May 8, 2025

The original commiter rolled back the change: 7f76af4. Let's wait for the change and we can add the tests again.

@luaifei
Copy link
Contributor Author

luaifei commented May 8, 2025

Sure @hangfei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants