fix(session): sqlalchemy query error in ·DatabaseSessionService by using GetSessionConfig #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om GetSessionConfig with PostgreSQL
DeanChensj
approved these changes
May 15, 2025
DeanChensj
added
ready to pull
|
Could you run |
copybara-service bot
pushed a commit
that referenced
this pull request
May 16, 2025
…om GetSessionConfig with PostgreSQL Copybara import of the project: -- cec6f50 by ZhiNing <[email protected]>: COPYBARA_INTEGRATE_REVIEW=#705 from czn574775237:fix/issue-655 c15f116 PiperOrigin-RevId: 759381068
|
commited in e62e15e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #655, resolving errors in the DatabaseSessionService when using GetSessionConfig with PostgreSQL. The changes fix the order of SQL query operations, improve handling of optional GetSessionConfig fields, and correct timestamp comparisons to prevent errors.