Stop Agent Execution button in ADK web #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have implemented the request cancellation logic in `agent.service.ts` using an `AbortController` and added a `stopSse` method. I have added the `stop()` method to `chat.component.ts` and connected it to the stop button. The new stop functionality is implemented as planned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jules.google has implemented the request cancellation logic in
agent.service.tsusing anAbortControllerand added astopSsemethod.I have added the
stop()method tochat.component.tsand connected it to the stop button.The new stop functionality is implemented as a 1 shot by jules, and jules was not able to run the test suite.
This might be a concept more than it is a real PR, but capturing it as an artifact. Feel free to reject.
Related to #9