Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/app/components/chat/chat.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
[eventData]="eventData"
[currentSessionState]="currentSessionState"
[artifacts]="artifacts"
[shouldShowEvalTab]="shouldShowEvalTab()"
[selectedEvent]="selectedEvent"
[selectedEventIndex]="selectedEventIndex"
[renderedEventGraph]="renderedEventGraph"
Expand All @@ -74,7 +73,6 @@
(eventSelected)="selectEvent($event)"
(sessionSelected)="updateWithSelectedSession($event)"
(sessionReloaded)="updateSessionState($event)"
(evalTabVisibilityChange)="handleShouldShowEvalTab($event)"
(evalCaseSelected)="updateWithSelectedEvalCase($event)"
(evalSetIdSelected)="updateSelectedEvalSetId($event)"
(returnToSession)="handleReturnToSession($event)"
Expand Down
5 changes: 0 additions & 5 deletions src/app/components/chat/chat.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ export class ChatComponent implements OnInit, AfterViewInit, OnDestroy {
private scrollContainer = viewChild.required<ElementRef>('autoScroll');
bottomPanelRef = viewChild.required<ElementRef>('bottomPanel');
private _snackBar = inject(MatSnackBar);
shouldShowEvalTab = signal(true);
enableSseIndicator = signal(false);
isChatMode = signal(true);
isEvalCaseEditing = signal(false);
Expand Down Expand Up @@ -1094,10 +1093,6 @@ export class ChatComponent implements OnInit, AfterViewInit, OnDestroy {
}
}

protected handleShouldShowEvalTab(shouldShow: boolean) {
this.shouldShowEvalTab.set(shouldShow);
}

protected handleReturnToSession(event: boolean) {
this.sessionTab()?.getSession(this.sessionId);
this.evalTab()?.resetEvalCase();
Expand Down
3 changes: 0 additions & 3 deletions src/app/components/side-panel/side-panel.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
>
</app-session-tab>
</mat-tab>
@if (shouldShowEvalTab) {
<mat-tab>
<ng-template mat-tab-label>
<span class="tab-label">{{ i18n.evalTabLabel }}</span>
Expand All @@ -69,15 +68,13 @@
[appName]="appName"
[userId]="userId"
[sessionId]="sessionId"
(shouldShowTab)="evalTabVisibilityChange.emit($event)"
(sessionSelected)="sessionSelected.emit($event)"
(evalCaseSelected)="evalCaseSelected.emit($event)"
(evalSetIdSelected)="evalSetIdSelected.emit($event)"
(shouldReturnToSession)="returnToSession.emit($event)"
(evalNotInstalledMsg)="evalNotInstalled.emit($event)"
></app-eval-tab>
</mat-tab>
}
</mat-tab-group>
</div>
} @if (this.selectedEvent && showSidePanel) {
Expand Down
26 changes: 0 additions & 26 deletions src/app/components/side-panel/side-panel.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,37 +320,11 @@ describe('SidePanelComponent', () => {
});

describe('Eval tab', () => {
beforeEach(() => {
component.shouldShowEvalTab = true;
fixture.detectChanges();
});

describe('when shouldShowEvalTab is true', () => {
beforeEach(async () => {
await switchTab(EVAL_TAB_INDEX);
});
it('is visible', () => {
expect(fixture.debugElement.query(EVAL_TAB_SELECTOR)).toBeTruthy();
});
});

describe('Interactions', () => {
beforeEach(async () => {
await switchTab(EVAL_TAB_INDEX);
});

describe('when app-eval-tab emits shouldShowTab', () => {
beforeEach(() => {
spyOn(component.evalTabVisibilityChange, 'emit');
const evalTab = fixture.debugElement.query(EVAL_TAB_SELECTOR);
evalTab.triggerEventHandler('shouldShowTab', false);
});
it('emits evalTabVisibilityChange', () => {
expect(component.evalTabVisibilityChange.emit)
.toHaveBeenCalledWith(false);
});
});

describe('when app-eval-tab emits evalCaseSelected', () => {
beforeEach(() => {
spyOn(component.evalCaseSelected, 'emit');
Expand Down
2 changes: 0 additions & 2 deletions src/app/components/side-panel/side-panel.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ export class SidePanelComponent {
@Input() eventData = new Map<string, any>();
@Input() currentSessionState: any;
@Input() artifacts: any[] = [];
@Input() shouldShowEvalTab = false;
@Input() selectedEvent: any|undefined;
@Input() selectedEventIndex: number|undefined;
@Input() renderedEventGraph: SafeHtml|undefined;
Expand All @@ -85,7 +84,6 @@ export class SidePanelComponent {
@Output() readonly eventSelected = new EventEmitter<string>();
@Output() readonly sessionSelected = new EventEmitter<Session>();
@Output() readonly sessionReloaded = new EventEmitter<Session>();
@Output() readonly evalTabVisibilityChange = new EventEmitter<boolean>();
@Output() readonly evalCaseSelected = new EventEmitter<EvalCase>();
@Output() readonly evalSetIdSelected = new EventEmitter<string>();
@Output() readonly returnToSession = new EventEmitter<boolean>();
Expand Down